Fix chat timeline row height estimation#1093
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
|
needs tests. also I think the estimation of |
308e1bb to
48a41c6
Compare
I added tests both unit and a browser render test. Let me know in case the browser test was a bit much and i can drop it. |
#1113 fixes the |
48a41c6 to
da366dd
Compare
What Changed
Improved chat timeline virtualization height estimation by switching from coarse message-only estimates to row-aware estimates for user messages, assistant messages, work groups, proposed plan cards, and the working indicator.
Assistant row estimates now also account for markdown structure and changed-files summaries, while proposed plans and work groups use estimators closer to their actual rendered shape.
Fixes: #1035
This PR supersedes #1054.
Why
Some chat rows were being underestimated, which could cause overlapping content and visible scroll instability in virtualized threads.
UI Changes
Same as Why ^
Checklist
Note
Fix chat timeline row height estimation to account for markdown, work groups, diff summaries, and proposed plans
estimateTimelineMessageHeightwith a unifiedestimateTimelineRowHeightin MessagesTimeline.tsx that handlesmessage,work,proposed-plan, andworkingrow kinds.resolveMessagesTimelineRowsin MessagesTimeline.logic.ts to precompute row state including completion divider flags, assistant diff summaries, and grouped work entries.Macroscope summarized 28fad63.